pkg/analyzer/test/src/context/context_test.dart - Issue 1212973003: Fix another new task model test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/test/src/context/context_test.dart

Issue 1212973003: Fix another new task model test (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/test/src/context/context_test.dart

diff --git a/pkg/analyzer/test/src/context/context_test.dart b/pkg/analyzer/test/src/context/context_test.dart

index 6aecc4fd5731edd51803a39ab857ff3aa303a5cf..3ea2f8c7d6feb9a881c3aae63dc0d9725e8f0fa0 100644

--- a/pkg/analyzer/test/src/context/context_test.dart

+++ b/pkg/analyzer/test/src/context/context_test.dart

@@ -45,6 +45,7 @@ import '../../generated/engine_test.dart';

import '../../generated/test_support.dart';

import '../../reflective_tests.dart';

import 'abstract_context.dart';

+import 'package:analyzer/src/task/html.dart';

main() {

groupSep = ' | ';

@@ -54,7 +55,7 @@ main() {

@reflectiveTest

class AnalysisContextImplTest extends AbstractContextTest {

- void fail_parseHtmlUnit_resolveDirectives() {

+ void test_parseHtmlUnit_resolveDirectives() {

Source libSource = addSource("/lib.dart", r'''

library lib;

class ClassA {}''');

@@ -70,25 +71,12 @@ class ClassA {}''');

<body>

</body>

</html>''');

- // TODO(brianwilkerson) Rewrite this. We need a way to get the AST for the

- // script.

-// Document document = context.parseHtmlDocument(source);

-// expect(document, isNotNull);

-// List<DartScript> scripts = context.computeResult(source, DART_SCRIPTS);

-// expect(scripts, hasLength(1));

-// CompilationUnit unit = context.computeResult(scripts[0], PARSED_AST);

-// ImportDirective importNode = unit.directives[0] as ImportDirective;

-// expect(importNode.uriContent, isNotNull);

-// expect(importNode.source, libSource);

- ht.HtmlUnit unit = context.parseHtmlUnit(source);

- expect(unit, isNotNull);

- // import directive should be resolved

- ht.XmlTagNode htmlNode = unit.tagNodes[0];

- ht.XmlTagNode headNode = htmlNode.tagNodes[0];

- ht.HtmlScriptTagNode scriptNode = headNode.tagNodes[0];

- CompilationUnit script = scriptNode.script;

- ImportDirective importNode = script.directives[0] as ImportDirective;

+ Document document = context.parseHtmlDocument(source);

+ expect(document, isNotNull);

+ List<DartScript> scripts = context.computeResult(source, DART_SCRIPTS);

+ expect(scripts, hasLength(1));

+ CompilationUnit unit = context.computeResult(scripts[0], PARSED_UNIT);

+ ImportDirective importNode = unit.directives[0] as ImportDirective;

expect(importNode.uriContent, isNotNull);

expect(importNode.source, libSource);

}

« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | no next file » | no next file with comments »