Add net::CertificateReportSender for handling cert report sending

net/http/certificate_report_sender_impl.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/certificate_report_sender_impl.h"
+
+#include "base/stl_util.h"
+#include "net/base/elements_upload_data_stream.h"
+#include "net/base/load_flags.h"
+#include "net/base/request_priority.h"
+#include "net/base/upload_bytes_element_reader.h"
+#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_status.h"
+
+namespace net {
+
+CertificateReportSenderImpl::CertificateReportSenderImpl(
+    URLRequestContext* request_context,
+    CookiesPreference cookies_preference)
+    : request_context_(request_context),
+      cookies_preference_(cookies_preference) {
+}
+
+CertificateReportSenderImpl::~CertificateReportSenderImpl() {
+  STLDeleteElements(&inflight_requests_);
+}
+
+void CertificateReportSenderImpl::Send(const GURL& report_uri,
+                                       const std::string& report) {
+  scoped_ptr<URLRequest> url_request =
+      CreateURLRequest(request_context_, report_uri);
+  url_request->set_method("POST");
+
+  scoped_ptr<UploadElementReader> reader(
+      UploadOwnedBytesElementReader::CreateWithString(report));
+  url_request->set_upload(
+      ElementsUploadDataStream::CreateWithReader(reader.Pass(), 0));
+
+  URLRequest* raw_url_request = url_request.get();
+  inflight_requests_.insert(url_request.release());
+  raw_url_request->Start();
+}
+
+void CertificateReportSenderImpl::OnResponseStarted(URLRequest* request) {
+  // TODO(estark): call a callback so that the caller can print a
+  // warning on failure.
+  RequestComplete(request);
+}
+
+void CertificateReportSenderImpl::OnReadCompleted(URLRequest* request,
+                                                  int bytes_read) {

[davidben, 2015/07/23 00:09:42]

Optional: Since you don't call Read, perhaps a NOTREACHED() here.

[estark, 2015/07/23 02:41:21]

Done.

+}
+
+scoped_ptr<URLRequest> CertificateReportSenderImpl::CreateURLRequest(
+    URLRequestContext* context,
+    const GURL& report_uri) {

[davidben, 2015/07/23 00:09:42]

Optional: You probably can just inline this method into Send. It's sort of odd
anyway with the explicit URLRequestContext parameter and half of configuration
happening instead and half outside.

[estark, 2015/07/23 02:41:21]

Tests for ChromeFraudulentCertificateReporter override this, for (historical?)
reasons that I've never really understood. I added a TODO to inline this after
ChromeFraudulentCertificateReporter goes away.

[davidben, 2015/07/24 18:54:11]

Ah sorry, I'd missed that.

+  scoped_ptr<URLRequest> request =
+      context->CreateRequest(report_uri, DEFAULT_PRIORITY, this);
+  int load_flags =
+      LOAD_BYPASS_CACHE | LOAD_DISABLE_CACHE | LOAD_DO_NOT_SEND_AUTH_DATA;
+  if (cookies_preference_ != SEND_COOKIES)

[davidben, 2015/07/23 00:09:41]

Nit: The body is more than one line, so I'd put the curlies in. (Well, these
days I don't like omitting curlies at all, but Chromium and net especially
disagree with me.)

[estark, 2015/07/23 02:41:21]

Done.

+    load_flags =
+        load_flags | LOAD_DO_NOT_SEND_COOKIES | LOAD_DO_NOT_SAVE_COOKIES;
+  request->SetLoadFlags(load_flags);
+  return request.Pass();
+}
+
+void CertificateReportSenderImpl::RequestComplete(URLRequest* request) {
+  std::set<URLRequest*>::iterator i = inflight_requests_.find(request);
+  CHECK(i != inflight_requests_.end());
+  scoped_ptr<URLRequest> url_request(*i);
+  inflight_requests_.erase(i);
+}
+
+}  // namespace net