Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1212963004: Mark SizeOfFirstPageIsLargeEnough failing on mips64 (Closed)

Created:
5 years, 5 months ago by Dan Ehrenberg
Modified:
5 years, 5 months ago
Reviewers:
adamk, paul.l...
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark SizeOfFirstPageIsLargeEnough failing on mips64 The failure was been triggered by turning on --harmony-arrays, maybe because code size was increased or code was added later in the bootstrap process. Because it doesn't look like a bug in anything guarded by --harmony-arrays directly, I'd suggest shipping the flag and disabling the test on the architectures where it's been observed to fail. It's already disabled on arm64 and this patch disables it on mips64 as well. BUG=v8:4200 LOG=N R=adamk Committed: https://crrev.com/40d01b57d93958e31a4e305bbd0d79b2eb8fc3da Cr-Commit-Position: refs/heads/master@{#29361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Dan Ehrenberg
5 years, 5 months ago (2015-06-29 05:20:20 UTC) #1
adamk
Not clear to me that mips64el is the same thing as mips64 that's referred to ...
5 years, 5 months ago (2015-06-29 23:58:18 UTC) #3
paul.l...
Yes, it is for mips64el, the patch LGTM. Thanks, Dan! Details: traditionally mips and mips64 ...
5 years, 5 months ago (2015-06-30 00:14:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212963004/1
5 years, 5 months ago (2015-06-30 00:17:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3827)
5 years, 5 months ago (2015-06-30 00:19:58 UTC) #8
paul.l...
On 2015/06/30 00:17:18, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 5 months ago (2015-06-30 00:20:08 UTC) #9
adamk
lgtm
5 years, 5 months ago (2015-06-30 00:20:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212963004/1
5 years, 5 months ago (2015-06-30 00:20:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 00:44:48 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 00:45:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40d01b57d93958e31a4e305bbd0d79b2eb8fc3da
Cr-Commit-Position: refs/heads/master@{#29361}

Powered by Google App Engine
This is Rietveld 408576698