Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: Source/core/paint/BoxBorderPainter.cpp

Issue 1212963002: Remove BackgroundBleedBackgroundOverBorder (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove BackgroundBleedBackgroundOverBorder Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.h ('k') | Source/core/paint/BoxDecorationData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/BoxBorderPainter.cpp
diff --git a/Source/core/paint/BoxBorderPainter.cpp b/Source/core/paint/BoxBorderPainter.cpp
index ec93135fec480059a472d9323a56572f444d7701..29cdc3e614127b304a46511691bb27acaa8d2a24 100644
--- a/Source/core/paint/BoxBorderPainter.cpp
+++ b/Source/core/paint/BoxBorderPainter.cpp
@@ -273,11 +273,6 @@ void drawBleedAdjustedDRRect(GraphicsContext* context, BackgroundBleedAvoidance
const FloatRoundedRect& outer, const FloatRoundedRect& inner, Color color)
{
switch (bleedAvoidance) {
- case BackgroundBleedBackgroundOverBorder:
- // BackgroundBleedBackgroundOverBorder draws an opaque background over the inner rrect,
- // so we can simply fill the outer rect here to avoid backdrop bleeding.
- context->fillRoundedRect(outer, color);
- break;
case BackgroundBleedClipLayer: {
// BackgroundBleedClipLayer clips the outer rrect for the whole layer. Based on this,
// we can avoid background bleeding by filling the *outside* of inner rrect, all the
@@ -599,9 +594,7 @@ void BoxBorderPainter::paintBorder(const PaintInfo& info, const LayoutRect& rect
if (!bleedAvoidanceIsClipping(m_bleedAvoidance))
graphicsContext->clipRoundedRect(m_outer);
- // For BackgroundBleedBackgroundOverBorder, we're going to draw an opaque background over
- // the inner rrect - so clipping is not needed (nor desirable due to backdrop bleeding).
- if (m_bleedAvoidance != BackgroundBleedBackgroundOverBorder && m_inner.isRenderable() && !m_inner.isEmpty())
+ if (m_inner.isRenderable() && !m_inner.isEmpty())
graphicsContext->clipOutRoundedRect(m_inner);
}
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.h ('k') | Source/core/paint/BoxDecorationData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698