Issue 1212963002: Remove BackgroundBleedBackgroundOverBorder

Issue 1212963002: Remove BackgroundBleedBackgroundOverBorder (Closed)

Created:
5 years, 5 months ago by f(malita)

Modified:
5 years, 5 months ago

Reviewers:
chrishtr, fs

CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, reed1, slimming-paint-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Remove BackgroundBleedBackgroundOverBorder After http://crrev.com/1089313003, the pre-condition for BackgroundBleedShrinkBackground is more inclusive than the pre-condition for BackgroundBleedBackgroundOverBorder. Since the former is the preferred bleed avoidance method, we are no longer using BackgroundBleedBackgroundOverBorder at all. Removing this dead code. R=fs@opera.com,chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197941

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -43 lines)			Patch
M	Source/core/layout/LayoutBox.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/layout/LayoutBox.cpp	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download
M	Source/core/layout/LayoutBoxModelObject.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/paint/BoxBorderPainter.cpp	View	1	2 chunks	+1 line, -8 lines	0 comments	Download
M	Source/core/paint/BoxDecorationData.cpp	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/paint/BoxPainter.cpp	View	1	3 chunks	+1 line, -6 lines	0 comments	Download

Total messages: 8 (4 generated)

f(malita)

As a sanity check, PS#1 ran the tests asserting that we're not hitting BackgroundBleedBackgroundOverBorder at ...

5 years, 5 months ago (2015-06-26 20:00:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212963002/20001

5 years, 5 months ago (2015-06-26 22:50:05 UTC) #7

commit-bot: I haz the power

5 years, 5 months ago (2015-06-26 22:55:13 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197941