Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: runtime/vm/pages.cc

Issue 1212943010: Safer interface for heap iteration. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix release mode. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/pages.h ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.cc
diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc
index 18eec36fe8a23a9102705f2b4ebeb7f99636d6cb..109df5006d1645276a0da2b269500890b5548fd8 100644
--- a/runtime/vm/pages.cc
+++ b/runtime/vm/pages.cc
@@ -160,6 +160,9 @@ PageSpace::PageSpace(Heap* heap,
max_external_in_words_(max_external_in_words),
tasks_lock_(new Monitor()),
tasks_(0),
+#if defined(DEBUG)
+ is_iterating_(false),
+#endif
page_space_controller_(heap,
FLAG_old_gen_growth_space_ratio,
FLAG_old_gen_growth_rate,
@@ -778,7 +781,7 @@ void PageSpace::MarkSweep(bool invoke_api_callbacks) {
if (FLAG_verify_before_gc) {
OS::PrintErr("Verifying before marking...");
- heap_->Verify();
+ heap_->VerifyGC();
OS::PrintErr(" done.\n");
}
@@ -810,7 +813,7 @@ void PageSpace::MarkSweep(bool invoke_api_callbacks) {
{
if (FLAG_verify_before_gc) {
OS::PrintErr("Verifying before sweeping...");
- heap_->Verify(kAllowMarked);
+ heap_->VerifyGC(kAllowMarked);
OS::PrintErr(" done.\n");
}
GCSweeper sweeper;
@@ -871,7 +874,7 @@ void PageSpace::MarkSweep(bool invoke_api_callbacks) {
}
if (FLAG_verify_after_gc) {
OS::PrintErr("Verifying after sweeping...");
- heap_->Verify(kForbidMarked);
+ heap_->VerifyGC(kForbidMarked);
OS::PrintErr(" done.\n");
}
} else {
« no previous file with comments | « runtime/vm/pages.h ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698