runtime/vm/dart_api_impl.cc - Issue 1212943010: Safer interface for heap iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1212943010: Safer interface for heap iteration. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix release mode. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 9868346f1e297e8ec82300cc4caa3d9858616155..17406eae2fbd2c8fbaae71abea9d7da5310f2193 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1522,7 +1522,7 @@ DART_EXPORT Dart_Handle Dart_CreateSnapshot(

isolate->heap()->CollectAllGarbage();

#if defined(DEBUG)

FunctionVisitor check_canonical(isolate);

- isolate->heap()->VisitObjects(&check_canonical);

+ isolate->heap()->IterateObjects(&check_canonical);

#endif // #if defined(DEBUG).

// Since this is only a snapshot the root library should not be set.

« no previous file with comments | « no previous file | runtime/vm/heap.h » ('j') | no next file with comments »