Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: runtime/observatory/lib/src/elements/service_view.dart

Issue 1212933003: Observatory improvements for exploring compiled code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/service_view.dart
diff --git a/runtime/observatory/lib/src/elements/service_view.dart b/runtime/observatory/lib/src/elements/service_view.dart
index afedd621ab3462408385db69ff4ad30ad001473d..f0c20626b657ba9b892a48228cde9fa81da0d808 100644
--- a/runtime/observatory/lib/src/elements/service_view.dart
+++ b/runtime/observatory/lib/src/elements/service_view.dart
@@ -78,9 +78,25 @@ class ServiceObjectViewElement extends ObservatoryElement {
element.connection = object;
return element;
case 'Object':
- ObjectViewElement element = new Element.tag('object-view');
- element.object = object;
- return element;
+ switch (object.vmType) {
+ case 'ICData':
+ ICDataViewElement element = new Element.tag('icdata-view');
+ element.icData = object;
+ return element;
+ case 'Instructions':
+ InstructionsViewElement element =
+ new Element.tag('instructions-view');
+ element.instructions = object;
+ return element;
+ case 'ObjectPool':
+ ObjectPoolViewElement element = new Element.tag('objectpool-view');
+ element.pool = object;
+ return element;
+ default:
+ ObjectViewElement element = new Element.tag('object-view');
+ element.object = object;
+ return element;
+ }
case 'SocketList':
IOSocketListViewElement element =
new Element.tag('io-socket-list-view');
« no previous file with comments | « runtime/observatory/lib/src/elements/service_ref.html ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698