Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: runtime/observatory/lib/src/elements/service_ref.html

Issue 1212933003: Observatory improvements for exploring compiled code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/service_ref.html
diff --git a/runtime/observatory/lib/src/elements/service_ref.html b/runtime/observatory/lib/src/elements/service_ref.html
index 097e90ccf8fd4d3c9a8f7dadfe80bd46e7db0a89..839b4c5295b7fd12f2c19a0050ca77b5484ff1f3 100644
--- a/runtime/observatory/lib/src/elements/service_ref.html
+++ b/runtime/observatory/lib/src/elements/service_ref.html
@@ -9,13 +9,31 @@
<polymer-element name="object-ref" extends="service-ref">
<template><link rel="stylesheet" href="css/shared.css">
- <template if="{{ nameIsEmpty }}">
- <a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.vmType }}</em></a>
+
+ <template if="{{ ref.isObjectPool }}">
+ <a on-click="{{ goto }}" _href="{{ url }}">
+ <em>{{ ref.vmType }}</em> ({{ ref.length }})
+ </a>
+ </template>
+ <template if="{{ ref.isICData }}">
+ <a on-click="{{ goto }}" _href="{{ url }}">
+ <em>{{ ref.vmType }}</em> ({{ ref.selector }})
+ </a>
+ </template>
+ <template if="{{ ref.isInstructions }}">
+ <a on-click="{{ goto }}" _href="{{ url }}">
+ <em>{{ ref.vmType }}</em> ({{ ref.code.name }})
+ </a>
</template>
- <template if="{{ !nameIsEmpty }}">
- <a on-click="{{ goto }}" _href="{{ url }}"><em>{{ name }}</em></a>
+ <template if="{{ !(ref.isObjectPool || ref.isICData || ref.isInstructions) }}">
+ <template if="{{ nameIsEmpty }}">
+ <a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.vmType }}</em></a>
+ </template>
+ <template if="{{ !nameIsEmpty }}">
+ <a on-click="{{ goto }}" _href="{{ url }}"><em>{{ name }}</em></a>
+ </template>
</template>
</template>
</polymer-element>
-<script type="application/dart" src="service_ref.dart"></script>
+<script type="application/dart" src="service_ref.dart"></script>
« no previous file with comments | « runtime/observatory/lib/src/elements/script_inset.dart ('k') | runtime/observatory/lib/src/elements/service_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698