Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12129002: Remove deprecated IPC code for onUpgradeNeeded/onSuccess/metadata (Closed)

Created:
7 years, 10 months ago by alecflett
Modified:
7 years, 10 months ago
Reviewers:
michaeln, Tom Sepez, jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, jsbell, dgrogan
Visibility:
Public.

Description

Remove deprecated IPC code for onUpgradeNeeded/onSuccess/metadata BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180029

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -133 lines) Patch
M content/browser/in_process_webkit/indexed_db_callbacks.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_callbacks.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.cc View 4 chunks +0 lines, -34 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 5 chunks +0 lines, -25 lines 1 comment Download
M content/common/indexed_db/proxy_webidbdatabase_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alecflett
michaeln@ - jsbell/dgrogan are out today, mind a quick review? it's entirely code removal tsepez@ ...
7 years, 10 months ago (2013-01-31 21:57:07 UTC) #1
Tom Sepez
Rubberstamp LTGM on message deletion.
7 years, 10 months ago (2013-01-31 21:59:14 UTC) #2
jsbell
driveby lgtm since I'm checking mail. https://codereview.chromium.org/12129002/diff/1/content/common/indexed_db/indexed_db_messages.h File content/common/indexed_db/indexed_db_messages.h (left): https://codereview.chromium.org/12129002/diff/1/content/common/indexed_db/indexed_db_messages.h#oldcode452 content/common/indexed_db/indexed_db_messages.h:452: // TODO: make ...
7 years, 10 months ago (2013-01-31 22:23:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/12129002/1
7 years, 10 months ago (2013-01-31 22:25:56 UTC) #4
commit-bot: I haz the power
Presubmit check for 12129002-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-01-31 22:26:00 UTC) #5
Tom Sepez
LGTM, not LTGM.
7 years, 10 months ago (2013-01-31 22:27:02 UTC) #6
alecflett
On 2013/01/31 21:59:14, Tom Sepez wrote: > Rubberstamp LTGM on message deletion. Tom, not sure ...
7 years, 10 months ago (2013-01-31 22:27:13 UTC) #7
alecflett
7 years, 10 months ago (2013-01-31 22:27:36 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 22:40:19 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698