Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Merge, convert pixel to ref tests, and address comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutObject.h ('k') | Source/core/layout/TracedLayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index 16ac690af84b0a27f460326e1de36c246c25bb80..0c2eda9270cb0b8fc461693ba9dd532f96517c23 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -1093,6 +1093,8 @@ String LayoutObject::decoratedName() const
name.append(" (positioned)");
if (isRelPositioned())
name.append(" (relative positioned)");
+ if (isStickyPositioned())
+ name.append(" (sticky positioned)");
if (isFloating())
name.append(" (floating)");
if (spannerPlaceholder())
@@ -2003,7 +2005,7 @@ void LayoutObject::propagateStyleToAnonymousChildren(bool blockChildrenOnly)
// Preserve the position style of anonymous block continuations as they can have relative position when
// they contain block descendants of relative positioned inlines.
- if (child->isRelPositioned() && toLayoutBlock(child)->isAnonymousBlockContinuation())
+ if (child->isInFlowPositioned() && toLayoutBlock(child)->isAnonymousBlockContinuation())
newStyle->setPosition(child->style()->position());
updateAnonymousChildStyle(*child, *newStyle);
« no previous file with comments | « Source/core/layout/LayoutObject.h ('k') | Source/core/layout/TracedLayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698