Source/core/style/ComputedStyle.h - Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/style/ComputedStyle.h

Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comments and merge. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/sticky/sticky-as-positioning-container.html ('K') | « Source/core/paint/DeprecatedPaintLayer.cpp ('k') | Source/core/style/ComputedStyleConstants.h » ('j') | Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/style/ComputedStyle.h

diff --git a/Source/core/style/ComputedStyle.h b/Source/core/style/ComputedStyle.h

index 92715a46241ec0bd28a2f73bd662b45776159f93..21635a433493669e4c694219e5140be2fe8f9421 100644

--- a/Source/core/style/ComputedStyle.h

+++ b/Source/core/style/ComputedStyle.h

@@ -466,7 +466,7 @@ public:

EPosition position() const { return static_cast<EPosition>(noninherited_flags.position); }

bool hasOutOfFlowPosition() const { return position() == AbsolutePosition || position() == FixedPosition; }

- bool hasInFlowPosition() const { return position() == RelativePosition; }

+ bool hasInFlowPosition() const { return position() == RelativePosition || position() == StickyPosition; }

bool hasViewportConstrainedPosition() const { return position() == FixedPosition; }

EFloat floating() const { return static_cast<EFloat>(noninherited_flags.floating); }