Source/core/layout/TracedLayoutObject.cpp - Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/TracedLayoutObject.cpp

Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comments and merge. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/sticky/sticky-as-positioning-container.html ('K') | « Source/core/layout/TracedLayoutObject.h ('k') | Source/core/paint/DeprecatedPaintLayer.cpp » ('j') | Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/TracedLayoutObject.cpp

diff --git a/Source/core/layout/TracedLayoutObject.cpp b/Source/core/layout/TracedLayoutObject.cpp

index 586e234b195e25efe1ab10adc3a99fb0ff12b761..68f5281b12a3a960c08690bfdbd5d7605bf8c6d5 100644

--- a/Source/core/layout/TracedLayoutObject.cpp

+++ b/Source/core/layout/TracedLayoutObject.cpp

@@ -31,6 +31,7 @@ TracedLayoutObject::TracedLayoutObject(const LayoutObject& object)

, m_isAnonymous(object.isAnonymous())

, m_isPositioned(object.isOutOfFlowPositioned())

, m_isRelPositioned(object.isRelPositioned())

+ , m_isStickyPositioned(object.isStickyPositioned())

, m_isFloating(object.isFloating())

, m_selfNeeds(object.selfNeedsLayout())

, m_positionedMovement(object.needsPositionedMovementLayout())

@@ -125,6 +126,8 @@ PassRefPtr<JSONObject> TracedLayoutObject::toJSON() const

json->setBoolean("anonymous", m_isAnonymous);

if (m_isRelPositioned)

json->setBoolean("relativePositioned", m_isRelPositioned);

+ if (m_isStickyPositioned)

+ json->setBoolean("stickyPositioned", m_isStickyPositioned);

if (m_isFloating)

json->setBoolean("float", m_isFloating);

if (m_children.size()) {