Side by Side Diff: LayoutTests/fast/css/sticky/sticky-as-positioning-container.html
Issue 1212893005:
Add position: sticky as supported position value when CSSStickyPosition is enabled. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Comments and merge.
Created 5 years, 5 months ago
Use n/p to move between diff chunks;
N/P to move between comments.
Draft comments are only viewable by you.
22 Tests that the absolute positioned child is positioned relative to the stick
y container. You should see only a
23 green box as this will cover up the red box above the sticky div.
Rick Byers
2015/07/03 01:43:55
Prefer ref tests over pixel tests: https://www.chr
Prefer ref tests over pixel tests:
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations.
Pixel tests are hard to maintain in general (and use a lot more storage space -
which has been a problem for the repo merge!).
Or perhaps a layout test seems adequate in this case too (just use the
testRunner API to disable generating pixel results).
flackr
2015/07/14 15:24:35
Done. Even though a layout test would have worked
On 2015/07/03 01:43:55, Rick Byers (Out until 7-23) wrote:
> Prefer ref tests over pixel tests:
>
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations.
> Pixel tests are hard to maintain in general (and use a lot more storage space
-
> which has been a problem for the repo merge!).
>
> Or perhaps a layout test seems adequate in this case too (just use the
> testRunner API to disable generating pixel results).
Done. Even though a layout test would have worked for this case I used a ref
test since I think it better describes the intended behavior.
Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled.
(Closed)
Created 5 years, 5 months ago by flackr
Modified 5 years, 5 months ago
Reviewers: Rick Byers, Timothy Loh, Ian Vollick, leviw_travelin_and_unemployed
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 12