Write skia_unittests.isolate and enable swarming for skia_unittests.

Write skia_unittests.isolate and enable swarming for skia_unittests.

BUG=98637
Committed: https://crrev.com/3d150020c67930bd9388d8c039439518f8ecfc0b
Cr-Commit-Position: refs/heads/master@{#336828}

[jbroman, 2015-06-29 19:55:18]

jbroman@chromium.org changed reviewers:
+ maruel@chromium.org

[jbroman, 2015-06-29 19:55:18]

I know very little about swarming, so please scrutinize to see whether I got
this right. I doubt this will save any time (for example, this binary runs in 0
seconds on my workstation), but I gathered the intention is to push all of the
unit test targets to swarming.

If this LGTY, I'll grab a skia/ owner to stamp.

[Marc-Antoine Ruel (Google), 2015-06-29 22:53:00]

On 2015/06/29 19:55:18, jbroman wrote:
> I know very little about swarming, so please scrutinize to see whether I got
> this right. I doubt this will save any time (for example, this binary runs in
0
> seconds on my workstation), but I gathered the intention is to push all of the
> unit test targets to swarming.
> 
> If this LGTY, I'll grab a skia/ owner to stamp.

This is great. There's a few Clang builders that fails with Swarming if the
target isn't pulled in all.gyp, see discussion in
https://codereview.chromium.org/1202573002/ so you can just skip
chromium.fyi.json for now and I'll do a follow up for these, it's not a big deal
anywa.

Thanks! lgtm

[jbroman, 2015-06-30 14:20:04]

jbroman@chromium.org changed reviewers:
+ thakis@chromium.org

[jbroman, 2015-06-30 14:20:05]

+thakis@ for build/ and skia/ ownership

[Nico, 2015-06-30 18:24:29]

cool, lgtm!

https://codereview.chromium.org/1212893004/diff/40001/skia/skia_unittests.iso...
File skia/skia_unittests.isolate (right):

https://codereview.chromium.org/1212893004/diff/40001/skia/skia_unittests.iso...
skia/skia_unittests.isolate:44: }
much boilerplate wow :-(

[jbroman, 2015-06-30 18:27:57]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2015-06-30 18:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@google.com
Link to the patchset: https://codereview.chromium.org/1212893004/#ps40001
(title: "revert chromium.fyi.json per maruel@")

[M-A Ruel, 2015-06-30 18:28:18]

https://codereview.chromium.org/1212893004/diff/40001/skia/skia_unittests.iso...
File skia/skia_unittests.isolate (right):

https://codereview.chromium.org/1212893004/diff/40001/skia/skia_unittests.iso...
skia/skia_unittests.isolate:44: }
On 2015/06/30 18:24:29, Nico wrote:
> much boilerplate wow :-(

The ASAN stuff (lines 26-39) is not really needed in practice, it's fine to drop
it.

[commit-bot: I haz the power, 2015-06-30 18:29:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212893004/40001

[commit-bot: I haz the power, 2015-06-30 18:43:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-30 18:45:41]

Patchset 3 (id:??) landed as
https://crrev.com/3d150020c67930bd9388d8c039439518f8ecfc0b
Cr-Commit-Position: refs/heads/master@{#336828}