Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1212883003: Include user email into document title before spooling (Closed)

Created:
5 years, 5 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include user email into document title before spooling Could be used to monitor print jobs on OS side. Windows spooler "owner" cannot be changed so we should modify title. Max title length increased from 50 to 80 better readability. BUG=504826 Committed: https://crrev.com/27e401c8a69340bbc6cfbae460eeae7646e2dbbf Cr-Commit-Position: refs/heads/master@{#337647}

Patch Set 1 #

Patch Set 2 : Thu Jul 2 18:26:35 PDT 2015 #

Patch Set 3 : Mon Jul 6 10:13:42 PDT 2015 #

Total comments: 3

Patch Set 4 : Mon Jul 6 17:58:01 PDT 2015 #

Patch Set 5 : Mon Jul 6 17:58:42 PDT 2015 #

Patch Set 6 : Mon Jul 6 18:22:14 PDT 2015 #

Patch Set 7 : Mon Jul 6 18:28:51 PDT 2015 #

Patch Set 8 : Tue Jul 7 10:19:02 PDT 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -20 lines) Patch
M chrome/common/cloud_print/cloud_print_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 2 3 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M printing/printing_utils.h View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M printing/printing_utils.cc View 1 2 3 4 5 6 7 1 chunk +39 lines, -5 lines 0 comments Download
M printing/printing_utils_unittest.cc View 1 2 3 4 6 1 chunk +29 lines, -9 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
Vitaly Buka (NO REVIEWS)
5 years, 5 months ago (2015-07-02 22:07:31 UTC) #2
Vitaly Buka (NO REVIEWS)
5 years, 5 months ago (2015-07-02 22:07:31 UTC) #3
Vitaly Buka (NO REVIEWS)
5 years, 5 months ago (2015-07-02 22:07:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212883003/20001
5 years, 5 months ago (2015-07-03 01:27:32 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/105711) (exceeded global ...
5 years, 5 months ago (2015-07-03 01:53:24 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212883003/20001
5 years, 5 months ago (2015-07-06 02:14:16 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/34874) (exceeded global ...
5 years, 5 months ago (2015-07-06 02:43:43 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212883003/40001
5 years, 5 months ago (2015-07-06 17:14:53 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-06 19:00:35 UTC) #17
Aleksey Shlyapnikov
https://codereview.chromium.org/1212883003/diff/40001/chrome/service/cloud_print/printer_job_handler.cc File chrome/service/cloud_print/printer_job_handler.cc (right): https://codereview.chromium.org/1212883003/diff/40001/chrome/service/cloud_print/printer_job_handler.cc#newcode796 chrome/service/cloud_print/printer_job_handler.cc:796: if (!job_details.job_owner_.empty()) { What if it is empty? We ...
5 years, 5 months ago (2015-07-06 23:06:25 UTC) #18
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1212883003/diff/40001/chrome/service/cloud_print/printer_job_handler.cc File chrome/service/cloud_print/printer_job_handler.cc (right): https://codereview.chromium.org/1212883003/diff/40001/chrome/service/cloud_print/printer_job_handler.cc#newcode796 chrome/service/cloud_print/printer_job_handler.cc:796: if (!job_details.job_owner_.empty()) { On 2015/07/06 23:06:25, Aleksey Shlyapnikov wrote: ...
5 years, 5 months ago (2015-07-07 01:22:50 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212883003/100001
5 years, 5 months ago (2015-07-07 01:23:19 UTC) #21
Aleksey Shlyapnikov
lgtm
5 years, 5 months ago (2015-07-07 01:29:22 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212883003/120001
5 years, 5 months ago (2015-07-07 01:30:08 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/70064) (exceeded global retry quota)
5 years, 5 months ago (2015-07-07 01:40:16 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212883003/140001
5 years, 5 months ago (2015-07-07 17:20:54 UTC) #29
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 5 months ago (2015-07-07 18:21:26 UTC) #30
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 18:22:14 UTC) #31
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/27e401c8a69340bbc6cfbae460eeae7646e2dbbf
Cr-Commit-Position: refs/heads/master@{#337647}

Powered by Google App Engine
This is Rietveld 408576698