Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1212853002: Componentization: enable linking core and modules separately. (Closed)

Created:
5 years, 6 months ago by tasak
Modified:
5 years, 5 months ago
Reviewers:
haraken, Nico
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Componentization: enable linking core and modules separately. BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197973

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/build/features.gypi View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/PositionWithAffinity.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tasak
PTAL? I would like to land this patch after https://codereview.chromium.org/1212123003/'s patch is commited.
5 years, 6 months ago (2015-06-26 12:46:59 UTC) #2
haraken
LGTM if thakis@ is happy about this.
5 years, 6 months ago (2015-06-26 12:51:14 UTC) #4
Nico
lgtm if it builds with clang-cl :-)
5 years, 6 months ago (2015-06-26 17:10:05 UTC) #5
tasak
Thank you for reviewing. I've just tested clang/win (use clang=1 for Windows component build) and ...
5 years, 5 months ago (2015-06-29 05:50:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212853002/1
5 years, 5 months ago (2015-06-29 05:50:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/41686)
5 years, 5 months ago (2015-06-29 08:01:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212853002/20001
5 years, 5 months ago (2015-06-29 08:09:56 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 09:29:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197973

Powered by Google App Engine
This is Rietveld 408576698