Removed adb_commands from android_forwarder

Removed adb_commands from android_forwarder

This is taken from https://codereview.chromium.org/1167173002/

BUG=476709
Committed: https://crrev.com/3ee06e143111965222e6a9c3f4b3b36e9adfc79b
Cr-Commit-Position: refs/heads/master@{#338135}

[sullivan, 2015-06-30 18:29:46]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[sullivan, 2015-06-30 18:29:53]

sullivan@chromium.org changed reviewers:
+ jbudorick@chromium.org

[commit-bot: I haz the power, 2015-06-30 18:33:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212813007/1

[jbudorick, 2015-06-30 19:11:37]

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/forwarders/android_forwarder.py (right):

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/forwarders/android_forwarder.py:141: (iface,
dns1, dns2))
nit: indentation

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/forwarders/android_forwarder.py:167:
(self.host_ip, self._device_iface))
nit: same

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/forwarders/android_forwarder.py:390: for
device in device_utils.DeviceUtils.HealthyDevices():
Ned was leaning away from using HealthyDevices over in android_device:
https://codereview.chromium.org/1211323004

Not sure if we want to do the same here or not.

[sullivan, 2015-06-30 19:29:50]

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
File tools/telemetry/telemetry/internal/forwarders/android_forwarder.py (right):

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/forwarders/android_forwarder.py:141: (iface,
dns1, dns2))
On 2015/06/30 19:11:37, jbudorick wrote:
> nit: indentation

Done.

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/forwarders/android_forwarder.py:167:
(self.host_ip, self._device_iface))
On 2015/06/30 19:11:37, jbudorick wrote:
> nit: same

Done.

https://codereview.chromium.org/1212813007/diff/1/tools/telemetry/telemetry/i...
tools/telemetry/telemetry/internal/forwarders/android_forwarder.py:390: for
device in device_utils.DeviceUtils.HealthyDevices():
On 2015/06/30 19:11:37, jbudorick wrote:
> Ned was leaning away from using HealthyDevices over in android_device:
> https://codereview.chromium.org/1211323004
> 
> Not sure if we want to do the same here or not.

Ned, WDYT?

[nednguyen, 2015-06-30 19:43:48]

nednguyen@google.com changed reviewers:
+ nednguyen@google.com

[nednguyen, 2015-06-30 19:43:49]

https://codereview.chromium.org/1212813007/diff/20001/tools/telemetry/telemet...
File tools/telemetry/telemetry/internal/forwarders/android_forwarder.py (right):

https://codereview.chromium.org/1212813007/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/forwarders/android_forwarder.py:390: for
device in device_utils.DeviceUtils.HealthyDevices():
This will definitely bite. (I was a victim in
https://code.google.com/p/chromium/issues/detail?id=505867)

I would wait for https://codereview.chromium.org/1211323004/ to be landed and
use android_device.GetDeviceSerials()

[sullivan, 2015-07-01 19:31:22]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-01 19:32:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212813007/40001

[commit-bot: I haz the power, 2015-07-01 20:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 20:56:33]

Dry run: This issue passed the CQ dry run.

[sullivan, 2015-07-09 19:07:50]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[sullivan, 2015-07-09 19:08:18]

PTAL

[commit-bot: I haz the power, 2015-07-09 19:09:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212813007/60001

[nednguyen, 2015-07-09 20:39:27]

lgtm

[commit-bot: I haz the power, 2015-07-09 20:43:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 20:43:01]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2015-07-09 20:46:16]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-07-09 20:46:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212813007/60001

[commit-bot: I haz the power, 2015-07-09 20:52:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-09 20:53:46]

Patchset 4 (id:??) landed as
https://crrev.com/3ee06e143111965222e6a9c3f4b3b36e9adfc79b
Cr-Commit-Position: refs/heads/master@{#338135}