Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1212803003: Fix tests which broke in https://codereview.chromium.org/1216013003. (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix tests which broke in https://codereview.chromium.org/1216013003. Actually the tests broke in https://github.com/domokit/mojo/commit/136e0d4da5c8cfb802c7b77fb811a5b5d1293003 ...but I had reset the results because I had changed all the coordinates, and didn't realise some of the changes were bad. TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/3cfb6b95e8f888689d1ba08b4c5a955566e009fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -77 lines) Patch
M sky/tests/examples/sector-expected.txt View 21 chunks +74 lines, -74 lines 0 comments Download
M sky/tests/examples/stocks-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/tests/widgets/buttons-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Hixie
5 years, 5 months ago (2015-06-29 21:05:02 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3cfb6b95e8f888689d1ba08b4c5a955566e009fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698