Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: chrome/browser/google/google_update_win.cc

Issue 1212783003: Make Win HRESULT into link to help-center. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: create link in updater where hresult is known Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/url_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_update_win.cc
diff --git a/chrome/browser/google/google_update_win.cc b/chrome/browser/google/google_update_win.cc
index ded32d60009810372666417244679c17f87a3477..18033b89fbf64336229682ac9b7cf78b7707820c 100644
--- a/chrome/browser/google/google_update_win.cc
+++ b/chrome/browser/google/google_update_win.cc
@@ -23,6 +23,7 @@
#include "base/time/time.h"
#include "base/win/scoped_bstr.h"
#include "base/win/windows_version.h"
+#include "chrome/common/url_constants.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/installer/util/browser_distribution.h"
#include "chrome/installer/util/helper.h"
@@ -719,7 +720,10 @@ void UpdateCheckDriver::OnUpgradeError(GoogleUpdateErrorCode error_code,
hresult_ = hresult;
installer_exit_code_ = installer_exit_code;
base::string16 error_msg =
- base::StringPrintf(L"%d: 0x%x", error_code_, hresult_);
+ base::StringPrintf(L"%d: <a href='%s0x%X' target=_blank>0x%X</a>",
+ error_code_, base::UTF8ToUTF16(
+ chrome::kUpgradeHelpCenterBaseURL).c_str(),
+ hresult_, hresult_);
if (installer_exit_code_ != -1)
error_msg += base::StringPrintf(L": %d", installer_exit_code_);
if (system_level_install_)
« no previous file with comments | « no previous file | chrome/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698