Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: Source/bindings/core/v8/RejectedPromises.cpp

Issue 1212773003: Also send the "reason" for rejectionhandled events (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/dom/resources/promise-rejection-events.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/RejectedPromises.cpp
diff --git a/Source/bindings/core/v8/RejectedPromises.cpp b/Source/bindings/core/v8/RejectedPromises.cpp
index da8c256eb49363300cfdb8cae1a1a1e825ff8882..3ed8d247ee5d1659fbe25554de1e4a079984cff1 100644
--- a/Source/bindings/core/v8/RejectedPromises.cpp
+++ b/Source/bindings/core/v8/RejectedPromises.cpp
@@ -94,7 +94,6 @@ public:
}
m_callStack.clear();
- m_exception.clear();
jochen (gone - plz use gerrit) 2015/06/29 07:17:48 without removing this line, m_exception would not
}
void revoke()
@@ -115,7 +114,7 @@ public:
init.setPromise(ScriptPromise(m_scriptState, value));
init.setReason(m_exception);
RefPtrWillBeRawPtr<PromiseRejectionEvent> event = PromiseRejectionEvent::create(m_scriptState, EventTypeNames::rejectionhandled, init);
- m_shouldLogToConsole &= target->dispatchEvent(event);
+ target->dispatchEvent(event);
}
if (m_shouldLogToConsole) {
« no previous file with comments | « LayoutTests/http/tests/dom/resources/promise-rejection-events.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698