Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212773003: Also send the "reason" for rejectionhandled events (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
haraken, domenic
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Also send the "reason" for rejectionhandled events The "promise" keeps the "reason" alive anyway BUG=495801 R=haraken@chromium.org,domenic@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197969

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M LayoutTests/fast/dom/promise-rejection-events-console.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/dom/resources/promise-rejection-events.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/RejectedPromises.cpp View 2 chunks +1 line, -2 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-06-29 07:17:06 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1212773003/diff/1/Source/bindings/core/v8/RejectedPromises.cpp File Source/bindings/core/v8/RejectedPromises.cpp (left): https://codereview.chromium.org/1212773003/diff/1/Source/bindings/core/v8/RejectedPromises.cpp#oldcode97 Source/bindings/core/v8/RejectedPromises.cpp:97: m_exception.clear(); without removing this line, m_exception would not be ...
5 years, 5 months ago (2015-06-29 07:17:48 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-06-29 07:22:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212773003/1
5 years, 5 months ago (2015-06-29 07:23:12 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 08:27:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197969

Powered by Google App Engine
This is Rietveld 408576698