Removal of UpdateMultivaluedField() as we now don't have multiple values for name,email and phone n…

Removal of UpdateMultivaluedField() as we now don't have multiple values for name,email and phone number as per unique profile GUID.

UpdateMultivaluedField() is no more needed.
Same can be achieved by UpdateField().

BUG=507208
Committed: https://crrev.com/1aa0126ec8eae48b752225ce49f6b37bb70c6e10
Cr-Commit-Position: refs/heads/master@{#338557}

[Deepak, 2015-07-06 10:08:33]

deepak.m1@samsung.com changed reviewers:
+ estade@chromium.org

[Deepak, 2015-07-06 10:08:33]

PTAL at this small change.

[Deepak, 2015-07-08 13:12:23]

deepak.m1@samsung.com changed reviewers:
+ vabr@chromium.org

[Deepak, 2015-07-08 13:12:23]

Please review.

[vabr (Chromium), 2015-07-08 13:20:04]

LGTM, but I'm not an OWNER of this code.

Normally, if you ask multiple people for review, it is helpful to let them know
what they should review. For small changes like this the owner's review should
be enough.

Cheers,
Vaclav

https://codereview.chromium.org/1212733005/diff/1/components/autofill/core/br...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(right):

https://codereview.chromium.org/1212733005/diff/1/components/autofill/core/br...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:327:
// Update all multivalued fields: names, emails, and phones.
The comment looks obsolete, please update.

[Deepak, 2015-07-08 14:53:36]

@Evan
Please review this small change.

https://codereview.chromium.org/1212733005/diff/1/components/autofill/core/br...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(right):

https://codereview.chromium.org/1212733005/diff/1/components/autofill/core/br...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:327:
// Update all multivalued fields: names, emails, and phones.
On 2015/07/08 13:20:04, vabr (Chromium) wrote:
> The comment looks obsolete, please update.

Done.

[Evan Stade, 2015-07-08 21:03:00]

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(right):

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:328:
::google::protobuf::RepeatedPtrField<std::string> values =
it doesn't seem like there's much purpose in this local variable, also you're
copying instead of referencing

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:331:
UpdateField(NAME_FIRST, values.size() < 1 ? std::string() : values.Get(0),
specifics.name_first().empty() ? std::string() : specifics.name_first(0)

ditto below

[Deepak, 2015-07-09 05:14:28]

@Evan
Changes done as suggested.
PTAL Thanks

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(right):

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:328:
::google::protobuf::RepeatedPtrField<std::string> values =
On 2015/07/08 21:03:00, Evan Stade wrote:
> it doesn't seem like there's much purpose in this local variable, also you're
> copying instead of referencing

Done.

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:331:
UpdateField(NAME_FIRST, values.size() < 1 ? std::string() : values.Get(0),
On 2015/07/08 21:03:00, Evan Stade wrote:
> specifics.name_first().empty() ? std::string() : specifics.name_first(0)
> 
> ditto below

we don't have .empty() for RepeatedPtrField, so I have to use .size() only.
I have updated the logic using .size() as
specifics.name_first().size() ? specifics.name_first(0): std::string()

[Evan Stade, 2015-07-09 19:06:56]

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(right):

https://codereview.chromium.org/1212733005/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:331:
UpdateField(NAME_FIRST, values.size() < 1 ? std::string() : values.Get(0),
On 2015/07/09 05:14:28, Deepak wrote:
> On 2015/07/08 21:03:00, Evan Stade wrote:
> > specifics.name_first().empty() ? std::string() : specifics.name_first(0)
> > 
> > ditto below
> 
> we don't have .empty() for RepeatedPtrField, so I have to use .size() only.
> I have updated the logic using .size() as
> specifics.name_first().size() ? specifics.name_first(0): std::string()

in that case you can use specifics.name_first_size()

https://codereview.chromium.org/1212733005/diff/40001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(right):

https://codereview.chromium.org/1212733005/diff/40001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:330:
: std::string(), profile) ||
regardless of whether this is git cl formatted, this line wrapping is suspect
and should be fixed (align profile with the other arguments to UpdateField)

[Deepak, 2015-07-10 06:09:54]

@Evan
Thanks for review.
Changes done as suggested.
PTAL

https://codereview.chromium.org/1212733005/diff/40001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
(right):

https://codereview.chromium.org/1212733005/diff/40001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc:330:
: std::string(), profile) ||
On 2015/07/09 19:06:55, Evan Stade wrote:
> regardless of whether this is git cl formatted, this line wrapping is suspect
> and should be fixed (align profile with the other arguments to UpdateField)

Done.

[Deepak, 2015-07-13 15:20:34]

Friendly Ping.:)

[Evan Stade, 2015-07-13 19:02:26]

lgtm

[Evan Stade, 2015-07-13 19:02:32]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-07-13 19:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1212733005/#ps60001
(title: "Changes as per review comments.")

[commit-bot: I haz the power, 2015-07-13 19:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212733005/60001

[commit-bot: I haz the power, 2015-07-13 20:21:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-13 20:22:48]

Patchset 4 (id:??) landed as
https://crrev.com/1aa0126ec8eae48b752225ce49f6b37bb70c6e10
Cr-Commit-Position: refs/heads/master@{#338557}