Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1212693002: Remove --enable-slimming-paint from layout test command line (Closed)

Created:
5 years, 6 months ago by Xianzhu
Modified:
5 years, 6 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove --enable-slimming-paint from layout test command line Slimming paint has been enabled by default, so we don't need to force it for layout tests. Also Android no longer blocks slimming paint. BUG=497950 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197940

Patch Set 1 #

Patch Set 2 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 chunk +1 line, -7 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Xianzhu
5 years, 6 months ago (2015-06-26 19:50:01 UTC) #2
pdr.
On 2015/06/26 at 19:50:01, wangxianzhu wrote: > LGTM
5 years, 6 months ago (2015-06-26 19:51:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212693002/20001
5 years, 6 months ago (2015-06-26 19:54:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197940
5 years, 6 months ago (2015-06-26 21:06:40 UTC) #6
chrishtr
Is this really safe? This keeps us from being able to easily turn off SP ...
5 years, 6 months ago (2015-06-26 23:31:01 UTC) #7
chrishtr
5 years, 6 months ago (2015-06-26 23:31:06 UTC) #8
Xianzhu
5 years, 6 months ago (2015-06-27 00:24:25 UTC) #9
Message was sent while issue was closed.
I created this CL because we couldn't easily turn off SP for layout tests with
"run-webkit-tests --additional-driver-flag=--disable-slimming-paint" as
--enable-slimming-paint in the python script has higher priority.

I think when we need to turn off SP, we can revert this CL first, or create
another CL to let --additional-driver-flag="--disable-slimming-paint" work.

Powered by Google App Engine
This is Rietveld 408576698