Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1212653011: X87: Vector ICs: Like megamorphic keyed koads, use a dummy vector for stores. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Vector ICs: Like megamorphic keyed koads, use a dummy vector for stores. port 9e7af9efc5857b3c7e23a77d257f3dfbea597753 (r29280). original commit message: It's useful for the megamorphic keyed store case to not require a vector and slot as input. Analogous to the load case, we have a dummy one-ic-slot vector to aid. Since the only kind of MISS is for megamorphic cache stub failures, we don't need the real vector. The reason is that megamorphic cache stub failures don't result in any change to the type feedback vector state. BUG= Committed: https://crrev.com/29686a2b54102039bc6cecb9eff1b1711daf750c Cr-Commit-Position: refs/heads/master@{#29410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/ic/x87/ic-x87.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-06-30 09:18:44 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 11:04:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212653011/1
5 years, 5 months ago (2015-07-01 11:04:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 11:47:06 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 11:47:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29686a2b54102039bc6cecb9eff1b1711daf750c
Cr-Commit-Position: refs/heads/master@{#29410}

Powered by Google App Engine
This is Rietveld 408576698