Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: base/strings/string_number_conversions_unittest.cc

Issue 1212653005: [ADANDONED] Helper code for finding problematic uses of IntToString variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@int_to_string_cleanup_net
Patch Set: Disable warnings on IntToString's own tests. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/strings/string_number_conversions.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/strings/string_number_conversions_unittest.cc
diff --git a/base/strings/string_number_conversions_unittest.cc b/base/strings/string_number_conversions_unittest.cc
index 0bc72f17ca10d48e0d9945e786c30c05e056b990..63aeedd21f58aa6a3297bb8d6d6b0da349947bfe 100644
--- a/base/strings/string_number_conversions_unittest.cc
+++ b/base/strings/string_number_conversions_unittest.cc
@@ -29,6 +29,8 @@ struct IntToStringTest {
} // namespace
+#if !defined(STRING_NUMBER_CONVERSIONS_DETECT_RISKY_CONVERSIONS)
+
TEST(StringNumberConversionsTest, IntToString) {
static const IntToStringTest<int> int_tests[] = {
{ 0, "0", "0" },
@@ -360,6 +362,8 @@ TEST(StringNumberConversionsTest, StringToUint64) {
EXPECT_EQ(6U, output);
}
+#endif // !defined(STRING_NUMBER_CONVERSIONS_DETECT_RISKY_CONVERSIONS)
+
TEST(StringNumberConversionsTest, StringToSizeT) {
size_t size_t_max = std::numeric_limits<size_t>::max();
std::string size_t_max_string = StringPrintf("%" PRIuS, size_t_max);
« no previous file with comments | « base/strings/string_number_conversions.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698