Issue 1212643009: Allow for an existing bad proxy to be given a new retry delay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1212643009: Allow for an existing bad proxy to be given a new retry delay. (Closed)

Created:
5 years, 5 months ago by sclittle

Modified:
5 years, 5 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow for an existing bad proxy to be given a new retry delay. Before this CL, any proxy that was previously marked as bad could not be assigned a different retry delay, and could only be marked as bad for the previous retry delay. This CL changes the proxy retry map update logic to replace the existing bad proxy retry info if the new retry time is later than the existing retry time. BUG=500738 Review URL: https://codereview.chromium.org/1191823002 Cr-Commit-Position: refs/heads/master@{#336451} (cherry picked from commit 08141d98705bc3a7ad0e53e64408adbf065eb554) Committed: https://chromium.googlesource.com/chromium/src/+/593db960e03bf850c2444b2dc13ede937c421afc

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -6 lines)			Patch
	M	net/proxy/proxy_list.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
	M	net/proxy/proxy_list_unittest.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sclittle

5 years, 5 months ago (2015-06-30 00:33:29 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
593db960e03bf850c2444b2dc13ede937c421afc.

Expand Messages | Collapse Messages