Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1212643005: DevTools: do not throw error to console on AddNewRule (Closed)

Created:
5 years, 5 months ago by lushnikov
Modified:
5 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not throw error to console on AddNewRule Obviously, an empty text is a valid text for a stylesheet. No need to throw. BUG=505358 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/sdk/CSSStyleModel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
lushnikov
ptal
5 years, 5 months ago (2015-06-29 12:47:31 UTC) #1
pfeldman
lgtm
5 years, 5 months ago (2015-06-29 12:48:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212643005/1
5 years, 5 months ago (2015-06-29 12:49:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68618)
5 years, 5 months ago (2015-06-29 15:34:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212643005/1
5 years, 5 months ago (2015-06-29 17:06:17 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 18:45:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198010

Powered by Google App Engine
This is Rietveld 408576698