Source/modules/serviceworkers/ServiceWorkerContainer.h - Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.h

Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/ServiceWorker.cpp ('K') | « Source/modules/serviceworkers/ServiceWorker.idl ('k') | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainer.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.h b/Source/modules/serviceworkers/ServiceWorkerContainer.h

index 6484728dc72c20ecb111d1ee9fe4ca4d7b34858e..dbc1742f146eb1a70134e0224d8010c32fb501bf 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainer.h

+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.h

@@ -68,7 +68,7 @@ public:

DECLARE_VIRTUAL_TRACE();

- PassRefPtrWillBeRawPtr<ServiceWorker> controller() { return m_controller.get(); }

+ ServiceWorker* controller() { return m_controller; }

ScriptPromise ready(ScriptState*);

WebServiceWorkerProvider* provider() { return m_provider; }

@@ -95,7 +95,7 @@ private:

ReadyProperty* createReadyProperty();

WebServiceWorkerProvider* m_provider;

- RefPtrWillBeMember<ServiceWorker> m_controller;

+ Member<ServiceWorker> m_controller;

Member<ReadyProperty> m_ready;

};