Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Work for a nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerMessagingProxy.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.h ('k') | Source/web/SharedWorkerRepositoryClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index 38b8c39e34613a7ae8d776fc7ec37f3711339930..8dc043e639b0f92687d319adbe5f27c5f11050bf 100644

--- a/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -218,7 +218,7 @@ void ServiceWorkerGlobalScopeProxy::workerGlobalScopeClosed()

void ServiceWorkerGlobalScopeProxy::willDestroyWorkerGlobalScope()

{

- m_workerGlobalScope = 0;

+ m_workerGlobalScope = nullptr;

m_client.willDestroyWorkerContext();

}

@@ -231,7 +231,7 @@ ServiceWorkerGlobalScopeProxy::ServiceWorkerGlobalScopeProxy(WebEmbeddedWorkerIm

: m_embeddedWorker(embeddedWorker)

, m_document(document)

, m_client(client)

- , m_workerGlobalScope(0)

+ , m_workerGlobalScope(nullptr)

{

}