Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: Source/modules/serviceworkers/ServiceWorker.h

Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorker.h
diff --git a/Source/modules/serviceworkers/ServiceWorker.h b/Source/modules/serviceworkers/ServiceWorker.h
index e446045cf7a38881d5a2de1a823531e70ded6295..5915615d0d04fb4d8eb94ce15632a2a06456dbac 100644
--- a/Source/modules/serviceworkers/ServiceWorker.h
+++ b/Source/modules/serviceworkers/ServiceWorker.h
@@ -49,16 +49,15 @@ class ScriptPromiseResolver;
class MODULES_EXPORT ServiceWorker final : public AbstractWorker, public WebServiceWorkerProxy {
DEFINE_WRAPPERTYPEINFO();
public:
- static PassRefPtrWillBeRawPtr<ServiceWorker> from(ExecutionContext*, WebServiceWorker*);
+ static ServiceWorker* from(ExecutionContext*, WebServiceWorker*);
~ServiceWorker() override;
// Eager finalization needed to promptly release owned WebServiceWorker.
EAGERLY_FINALIZE();
-#if ENABLE(OILPAN)
+
// Override 'operator new' to enforce allocation of eagerly finalized object.
DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();
-#endif
void postMessage(ExecutionContext*, PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, ExceptionState&);
@@ -74,7 +73,7 @@ public:
void internalsTerminate();
private:
- static PassRefPtrWillBeRawPtr<ServiceWorker> getOrCreate(ExecutionContext*, WebServiceWorker*);
+ static ServiceWorker* getOrCreate(ExecutionContext*, WebServiceWorker*);
ServiceWorker(ExecutionContext*, PassOwnPtr<WebServiceWorker>);
// ActiveDOMObject overrides.

Powered by Google App Engine
This is Rietveld 408576698