Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212643002: [Telemetry] Remove adb_commands usage from android_device. (Closed)

Created:
5 years, 6 months ago by nednguyen
Modified:
5 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove adb_commands usage from android_device. BUG=476709 Committed: https://crrev.com/fca25ba372bc2d5f8309dd9db837779b7faaffdd Cr-Commit-Position: refs/heads/master@{#336325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -127 lines) Patch
M tools/telemetry/telemetry/core/platform/android_device.py View 4 chunks +17 lines, -32 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_device_unittest.py View 1 chunk +81 lines, -95 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
nednguyen
5 years, 6 months ago (2015-06-25 22:52:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212643002/1
5 years, 6 months ago (2015-06-25 23:14:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-26 00:25:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212643002/1
5 years, 6 months ago (2015-06-26 00:44:28 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-26 00:44:31 UTC) #10
jbudorick
lgtm
5 years, 6 months ago (2015-06-26 01:31:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212643002/1
5 years, 6 months ago (2015-06-26 02:23:28 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 02:28:01 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fca25ba372bc2d5f8309dd9db837779b7faaffdd Cr-Commit-Position: refs/heads/master@{#336325}
5 years, 6 months ago (2015-06-26 02:29:04 UTC) #15
Paweł Hajdan Jr.
5 years, 6 months ago (2015-06-26 11:01:00 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1212333002/ by phajdan.jr@chromium.org.

The reason for reverting is: Speculative revert, see
https://code.google.com/p/chromium/issues/detail?id=504707.

Powered by Google App Engine
This is Rietveld 408576698