chrome/android/BUILD.gn - Issue 1212633005: [Feedback] Start using enum for connectivity check results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/BUILD.gn

Issue 1212633005: [Feedback] Start using enum for connectivity check results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityChecker.java » ('j') | chrome/browser/android/feedback/connectivity_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn

index 6559a39f74665a38e9435990f990f5d3548bd668..24b0f200983d4aab95b63b2481ca0868d3313a03 100644

--- a/chrome/android/BUILD.gn

+++ b/chrome/android/BUILD.gn

@@ -169,6 +169,7 @@ android_library("chrome_java") {

}

# GYP: //chrome/chrome_browser.gypi:activity_type_ids_java

+# GYP: //chrome/chrome_browser.gypi:connectivity_check_result_java

# GYP: //chrome/chrome_browser.gypi:profile_account_management_metrics_java

# GYP: //chrome/chrome_browser.gypi:profile_sync_service_model_type_selection_java

# GYP: //chrome/chrome_browser.gypi:connection_security_security_levels_java

@@ -176,6 +177,7 @@ android_library("chrome_java") {

java_cpp_enum("chrome_android_java_enums_srcjar") {

sources = [

"//chrome/browser/android/activity_type_ids.h",

+ "//chrome/browser/android/feedback/connectivity_checker.cc",

"//chrome/browser/android/tab_android.h",

"//chrome/browser/profiles/profile_metrics.h",

"//chrome/browser/ssl/connection_security.h",