[Feedback] Start using enum for connectivity check results

[Feedback] Start using enum for connectivity check results

Previously the feedback system would only get information about whether a
connection failed or not. This CL adds more information describing which
type of error occured, such as a timeout.

It also starts using the @Feature annotation for all the instrumentation
tests.

BUG=386395
Committed: https://crrev.com/199675e287d918419b4940332c05235b7d6fc570
Cr-Commit-Position: refs/heads/master@{#337089}

[nyquist, 2015-06-30 21:02:41]

nyquist@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[nyquist, 2015-06-30 21:02:42]

dfalcantara: PTAL

[nyquist, 2015-06-30 21:16:38]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-30 21:18:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212633005/1

[commit-bot: I haz the power, 2015-06-30 21:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 21:34:07]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[nyquist, 2015-07-01 14:53:59]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-01 14:54:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212633005/20001

[commit-bot: I haz the power, 2015-07-01 15:32:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-01 15:32:03]

Dry run: This issue passed the CQ dry run.

[gone, 2015-07-01 15:56:48]

lgtm

https://codereview.chromium.org/1212633005/diff/1/chrome/browser/android/feed...
File chrome/browser/android/feedback/connectivity_checker.cc (right):

https://codereview.chromium.org/1212633005/diff/1/chrome/browser/android/feed...
chrome/browser/android/feedback/connectivity_checker.cc:80: // and the timeout
flag set.
This sentence is weird; it took me several tries to parse it.

https://codereview.chromium.org/1212633005/diff/20001/chrome/android/javatest...
File
chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java
(right):

https://codereview.chromium.org/1212633005/diff/20001/chrome/android/javatest...
chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java:57:
for (Map.Entry<Type, Integer> re : result.entrySet()) {
Can't you rename the map "results" and "re" to "result"?  "re" is weird.

[nyquist, 2015-07-01 17:27:54]

nyquist@chromium.org changed reviewers:
+ thakis@chromium.org

[nyquist, 2015-07-01 17:27:54]

thakis: PTAL chrome/chrome.gyp

[Nico, 2015-07-01 17:33:19]

lgtm

[nyquist, 2015-07-01 18:39:19]

https://codereview.chromium.org/1212633005/diff/20001/chrome/android/javatest...
File
chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java
(right):

https://codereview.chromium.org/1212633005/diff/20001/chrome/android/javatest...
chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java:57:
for (Map.Entry<Type, Integer> re : result.entrySet()) {
On 2015/07/01 15:56:48, dfalcantara wrote:
> Can't you rename the map "results" and "re" to "result"?  "re" is weird.

Done.

[nyquist, 2015-07-01 18:39:26]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2015-07-01 18:39:27]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1212633005/#ps40001
(title: "Rename result and re to results and result in ConnectivityTask")

[commit-bot: I haz the power, 2015-07-01 18:39:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212633005/40001

[commit-bot: I haz the power, 2015-07-01 19:22:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-01 19:23:15]

Patchset 3 (id:??) landed as
https://crrev.com/199675e287d918419b4940332c05235b7d6fc570
Cr-Commit-Position: refs/heads/master@{#337089}