Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

Issue 1212613009: dart2js: Implement frequency based naming. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reserve reserved names :) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
index 134e6cf7c5c58c0f1c1de1c6c5526fdf46caf968..5d7df35210e3da68bf1c1c7cc827ea5f54809393 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
@@ -291,16 +291,17 @@ class NsmEmitter extends CodeEmitterHelper {
///
/// See [buildTrivialNsmHandlers].
class _DiffEncodedListOfNames extends jsAst.DeferredString
- implements AstContainer {
+ implements jsAst.AstContainer {
String _cachedValue;
- jsAst.ArrayInitializer ast;
+ List<jsAst.ArrayInitializer> ast;
+
+ Iterable<jsAst.Node> get containedNodes => ast;
_DiffEncodedListOfNames(Iterable<Iterable<jsAst.Name>> names) {
// Store the names in ArrayInitializer nodes to make them discoverable
// by traversals of the ast.
- ast = new jsAst.ArrayInitializer(
- names.map((Iterable i) => new jsAst.ArrayInitializer(i.toList()))
- .toList());
+ ast = names.map((Iterable i) => new jsAst.ArrayInitializer(i.toList()))
+ .toList();
}
void _computeDiffEncodingForList(Iterable<jsAst.Name> names,
@@ -367,7 +368,7 @@ class _DiffEncodedListOfNames extends jsAst.DeferredString
String _computeDiffEncoding() {
StringBuffer buffer = new StringBuffer();
- for (jsAst.ArrayInitializer list in ast.elements) {
+ for (jsAst.ArrayInitializer list in ast) {
if (buffer.isNotEmpty) {
// Emit period that resets the diff base to zero when we switch to
// normal calling convention (this avoids the need to code negative
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698