Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: net/spdy/spdy_session.cc

Issue 1212613004: Build and send HPKP violation reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary net::'s Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index e61104230a22ce16c11fcfca813e9997f9acb42a..f117ab2e1799fcffff4f0a79e4c48468b3948863 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -598,10 +598,17 @@ bool SpdySession::CanPool(TransportSecurityState* transport_security_state,
return false;
std::string pinning_failure_log;
+ // DISABLE_PIN_REPORTS is set here because this check can fail in
+ // normal operation without being indicative of a misconfiguration or
+ // attack.
+ //
+ // TODO(estark): replace 0 below with the port of the connection
+ // (though it won't actually be used since reports aren't getting
+ // sent).
if (!transport_security_state->CheckPublicKeyPins(
- new_hostname,
- ssl_info.is_issued_by_known_root,
- ssl_info.public_key_hashes,
+ HostPortPair(new_hostname, 0), ssl_info.is_issued_by_known_root,
+ ssl_info.public_key_hashes, ssl_info.unverified_cert.get(),
+ ssl_info.cert.get(), TransportSecurityState::DISABLE_PIN_REPORTS,
&pinning_failure_log)) {
return false;
}
« net/http/transport_security_state.cc ('K') | « net/socket/ssl_client_socket_openssl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698