Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 1212613004: Build and send HPKP violation reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary net::'s Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index 0963814dfe9779f2d6761433ad2ca2389c51b892..ec4a5c4e2e9a562cb83291012fe4432ae8a6d8e3 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -73,6 +73,7 @@
#include "net/proxy/proxy_service.h"
#include "net/ssl/channel_id_service.h"
#include "net/ssl/client_cert_store.h"
+#include "net/url_request/certificate_report_sender.h"
#include "net/url_request/data_protocol_handler.h"
#include "net/url_request/file_protocol_handler.h"
#include "net/url_request/ftp_protocol_handler.h"
@@ -640,6 +641,11 @@ ProfileIOData::~ProfileIOData() {
static_cast<void*>(it->second), sizeof(void*));
}
+ // Destroy certificate_report_sender_ before main_request_context_,
+ // since the former has a reference to the latter.
+ transport_security_state_->SetReportSender(nullptr);
+ certificate_report_sender_.reset();
+
// TODO(ajwong): These AssertNoURLRequests() calls are unnecessary since they
// are already done in the URLRequestContext destructor.
if (main_request_context_)
@@ -1059,6 +1065,11 @@ void ProfileIOData::Init(
base::SequencedWorkerPool::BLOCK_SHUTDOWN),
IsOffTheRecord()));
+ certificate_report_sender_.reset(new net::CertificateReportSender(
+ main_request_context_.get(),
+ net::CertificateReportSender::DO_NOT_SEND_COOKIES));
+ transport_security_state_->SetReportSender(certificate_report_sender_.get());
+
// Take ownership over these parameters.
cookie_settings_ = profile_params_->cookie_settings;
host_content_settings_map_ = profile_params_->host_content_settings_map;

Powered by Google App Engine
This is Rietveld 408576698