src/public/nonsfi/irt_exception_handling.h - Issue 1212613002: Non-SFI mode: Add Linux asynchronous signal support

Side by Side Diff: src/public/nonsfi/irt_exception_handling.h

Issue 1212613002: Non-SFI mode: Add Linux asynchronous signal support (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Disabled the async signal test for glibc Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 /*

2 * Copyright (c) 2014 The Native Client Authors. All rights reserved.

3 * Use of this source code is governed by a BSD-style license that can be

4 * found in the LICENSE file.

5 */

6

7 #ifndef NATIVE_CLIENT_SRC_PUBLIC_NONSFI_IRT_EXCEPTION_HANDLING_H_

8 #define NATIVE_CLIENT_SRC_PUBLIC_NONSFI_IRT_EXCEPTION_HANDLING_H_ 1

9

10 #include "native_client/src/include/nacl_base.h"

11

12 EXTERN_C_BEGIN

13

14 /* Initialize signal handler at startup before entering sandbox. */

15 void nonsfi_initialize_signal_handler(void);
Mark Seaborn 2015/08/12 01:43:06 Removing this from src/public/ would break the DEP Removing this from src/public/ would break the DEPS roll into Chromium. This is referred to by components/nacl/loader/nacl_helper_linux.cc. Please stage the change so that a trivial DEPS roll will work. How about just keeping the function name and header file name the same? Luis Héctor Chávez 2015/08/12 22:14:25 The DEPS roll would also be broken by the flags ch Show quoted text On 2015/08/12 01:43:06, Mark Seaborn wrote: > Removing this from src/public/ would break the DEPS roll into Chromium. This is > referred to by components/nacl/loader/nacl_helper_linux.cc. Please stage the > change so that a trivial DEPS roll will work. > > How about just keeping the function name and header file name the same? The DEPS roll would also be broken by the flags change in the call to clone(). Should I do the roll to make sure both this and the corresponding sandbox change are done in the same change? Mark Seaborn 2015/08/13 21:17:50 No, it's better to avoid non-trivial DEPS rolls wh Show quoted text On 2015/08/12 22:14:25, Luis Héctor Chávez wrote: > On 2015/08/12 01:43:06, Mark Seaborn wrote: > > Removing this from src/public/ would break the DEPS roll into Chromium. This > is > > referred to by components/nacl/loader/nacl_helper_linux.cc. Please stage the > > change so that a trivial DEPS roll will work. > > > > How about just keeping the function name and header file name the same? > > The DEPS roll would also be broken by the flags change in the call to clone(). > Should I do the roll to make sure both this and the corresponding sandbox change > are done in the same change? No, it's better to avoid non-trivial DEPS rolls whenever possible. See: https://docs.google.com/document/d/1jHoLo9I3CCS1_-4KlIq1OiEMv9cmMuXES2Z9JVpmP... Can you change the Chromium side to allow the new clone() flags first? Luis Héctor Chávez 2015/08/13 22:48:12 Done. Show quoted text On 2015/08/13 21:17:50, Mark Seaborn wrote: > On 2015/08/12 22:14:25, Luis Héctor Chávez wrote: > > On 2015/08/12 01:43:06, Mark Seaborn wrote: > > > Removing this from src/public/ would break the DEPS roll into Chromium. > This > > is > > > referred to by components/nacl/loader/nacl_helper_linux.cc. Please stage > the > > > change so that a trivial DEPS roll will work. > > > > > > How about just keeping the function name and header file name the same? > > > > The DEPS roll would also be broken by the flags change in the call to clone(). > > Should I do the roll to make sure both this and the corresponding sandbox > change > > are done in the same change? > > No, it's better to avoid non-trivial DEPS rolls whenever possible. > > See: > https://docs.google.com/document/d/1jHoLo9I3CCS1_-4KlIq1OiEMv9cmMuXES2Z9JVpmP... > > Can you change the Chromium side to allow the new clone() flags first? Done.
16

17 EXTERN_C_END

18

19 #endif

OLD	NEW

« src/nonsfi/linux/nonsfi_signal.h ('K') | « src/public/linux_syscalls/sys/syscall.h ('k') | src/public/nonsfi/irt_signal_handling.h » ('j') | src/public/nonsfi/irt_signal_handling.h » ('J')