Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 1212603002: Fix encrypted-media-syntax.html layout test (Closed)

Created:
4 years, 10 months ago by jrummell
Modified:
4 years, 10 months ago
Reviewers:
ddorwin
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix encrypted-media-syntax.html layout test Recent changes to V8 now pass 'Uint8Array(0)' as the empty string rather than converting it to "[object Uint8Array]", which changes the error returned when the promise fails. BUG=502308, 504458 TEST=updated test passes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-syntax.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jrummell
PTAL.
4 years, 10 months ago (2015-06-25 21:38:45 UTC) #2
ddorwin
lgtm Thanks!
4 years, 10 months ago (2015-06-25 22:07:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212603002/1
4 years, 10 months ago (2015-06-25 22:09:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197867
4 years, 10 months ago (2015-06-25 23:09:37 UTC) #6
eae
4 years, 10 months ago (2015-06-25 23:16:06 UTC) #7
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698