src/codec/SkJpegCodec.h - Issue 1212593003: Destroy SkScanlineDecoder in the SkCodec subclass destructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkJpegCodec.h

Issue 1212593003: Destroy SkScanlineDecoder in the SkCodec subclass destructors (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Detachable SkScanlineDecoder Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkJpegCodec.h

diff --git a/src/codec/SkJpegCodec.h b/src/codec/SkJpegCodec.h

index 87c925d9d17a49ca42ce96b91760f8259e1f33bf..f39bc49910dad8f40f8d853b6bb266178f5b399c 100644

--- a/src/codec/SkJpegCodec.h

+++ b/src/codec/SkJpegCodec.h

@@ -95,6 +95,12 @@ private:

SkJpegCodec(const SkImageInfo& srcInfo, SkStream* stream, JpegDecoderMgr* decoderMgr);

+ * Explicit destructor is used to ensure that the scanline decoder is deleted

+ * before the decode manager.

+ */

+ ~SkJpegCodec() override;

+ /*

* Handles rewinding the input stream if it is necessary

bool handleRewind();