Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1212553002: Fixing avr-gcc link errors due to incorrect assumptions in the spec file about avr-libc directory s… (Closed)

Created:
5 years, 6 months ago by gdeepti
Modified:
5 years, 5 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Fixing avr-gcc link errors due to incorrect assumptions in the spec file about avr-libc directory structure. BUG=None TEST=Trybots R=bradnelson@google.com, bradnelson@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/445fa337fa5c2176996535a00ea2ecb484c4b783

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M ports/gcc-avr/nacl.patch View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
gdeepti
5 years, 6 months ago (2015-06-25 21:55:17 UTC) #1
bradn
lgtm
5 years, 6 months ago (2015-06-25 22:04:55 UTC) #3
bradn
Put reference to the upstream bug in the comment.
5 years, 6 months ago (2015-06-25 22:05:16 UTC) #4
gdeepti
On 2015/06/25 22:05:16, bradn wrote: > Put reference to the upstream bug in the comment. ...
5 years, 5 months ago (2015-07-24 21:30:02 UTC) #5
gdeepti
5 years, 5 months ago (2015-07-24 21:32:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
445fa337fa5c2176996535a00ea2ecb484c4b783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698