net/http/http_stream_factory_impl_request.h - Issue 1212493003: Fix accounting and logging of HttpStream request and job bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_request.h

Issue 1212493003: Fix accounting and logging of HttpStream request and job bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stream-job-logging

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | net/http/http_stream_factory_impl_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory_impl_request.h

diff --git a/net/http/http_stream_factory_impl_request.h b/net/http/http_stream_factory_impl_request.h

index 48c85b20df7ab945e50d39007b5a3c6cbfc35a97..f553d4aecea74096b8d354cc8807a4b34518de90 100644

--- a/net/http/http_stream_factory_impl_request.h

+++ b/net/http/http_stream_factory_impl_request.h

@@ -48,11 +48,9 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {

void AttachJob(HttpStreamFactoryImpl::Job* job);

// Marks completion of the request. Must be called before OnStreamReady().

- // |job_net_log| is the BoundNetLog of the Job that fulfilled this request.

void Complete(bool was_npn_negotiated,

NextProto protocol_negotiated,

- bool using_spdy,

- const BoundNetLog& job_net_log);

+ bool using_spdy);

// If this Request has a |spdy_session_key_|, remove this session from the

// SpdySessionRequestMap.

« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | net/http/http_stream_factory_impl_request.cc » ('J')