ASSERT -> RELEASE_ASSERT for investigation of issue 466793

ASSERT -> RELEASE_ASSERT for investigation of issue 466793

The crash dump attached to isse 466793 suggests that we sometimes
retain a references to destroyed instances of Canvas2DLayerBridge
in Canvas2DLayerManager. This crash is extremely rare and we
have no repro steps. This change substitutes an assert for a release_assert
in order to trap crash dumps at the time the destructor is called
to help investigate conditions under which the invalid state is
generated.

BUG=466793
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197851

[Justin Novosad, 2015-06-25 15:53:36]

junov@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Justin Novosad, 2015-06-25 15:53:37]

PTAL

[Stephen Chennney, 2015-06-25 16:26:24]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2015-06-25 16:26:24]

Drive by.

https://codereview.chromium.org/1212483002/diff/1/Source/platform/graphics/Ca...
File Source/platform/graphics/Canvas2DLayerBridge.cpp (left):

https://codereview.chromium.org/1212483002/diff/1/Source/platform/graphics/Ca...
Source/platform/graphics/Canvas2DLayerBridge.cpp:122:
ASSERT(!Canvas2DLayerManager::get().isInList(this));
Why not just change this to RELEASE_ASSERT(...)?

[Justin Novosad, 2015-06-25 17:06:02]

On 2015/06/25 16:26:24, Stephen Chenney wrote:
> Drive by.
> 
>
https://codereview.chromium.org/1212483002/diff/1/Source/platform/graphics/Ca...
> File Source/platform/graphics/Canvas2DLayerBridge.cpp (left):
> 
>
https://codereview.chromium.org/1212483002/diff/1/Source/platform/graphics/Ca...
> Source/platform/graphics/Canvas2DLayerBridge.cpp:122:
> ASSERT(!Canvas2DLayerManager::get().isInList(this));
> Why not just change this to RELEASE_ASSERT(...)?

Ah, a new blink-ism to add to my vocabulary. Thanks.

[Stephen White, 2015-06-25 17:41:48]

LGTM

[Justin Novosad, 2015-06-25 17:42:15]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2015-06-25 17:42:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212483002/20001

[commit-bot: I haz the power, 2015-06-25 20:13:09]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197851