Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1212443006: JNI SampleForTests updated with clearer name for caller object. (Closed)

Created:
5 years, 5 months ago by scheib
Modified:
5 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-discovery-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

JNI SampleForTests updated with clearer name for caller object. When calling to C++ from Java the second parameter name is improved from 'obj' to 'caller' to better indicate what jobject is. Committed: https://crrev.com/e01c44804bbd8c7af3899c27cfca6676e853b2b2 Cr-Commit-Position: refs/heads/master@{#337714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java View 4 chunks +4 lines, -4 lines 0 comments Download
M base/android/jni_generator/sample_for_tests.h View 1 chunk +6 lines, -6 lines 0 comments Download
M base/android/jni_generator/sample_for_tests.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
scheib
Let's improve the suggested naming convention for JNI Java -> C++ function signatures. What do ...
5 years, 5 months ago (2015-07-07 23:32:34 UTC) #2
nyquist
lgtm
5 years, 5 months ago (2015-07-08 00:48:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212443006/1
5 years, 5 months ago (2015-07-08 00:58:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 01:34:59 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 01:35:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e01c44804bbd8c7af3899c27cfca6676e853b2b2
Cr-Commit-Position: refs/heads/master@{#337714}

Powered by Google App Engine
This is Rietveld 408576698