Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212423002: Fixing bad angle computation in 2D canvas arc rendering (Closed)

Created:
5 years, 6 months ago by Justin Novosad
Modified:
5 years, 6 months ago
Reviewers:
Stephen White
CC:
blink-reviews, dshwang, blink-reviews-html_chromium.org, dglazkov+blink, Rik, Justin Novosad
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixing bad angle computation in 2D canvas arc rendering BUG=503422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197931

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixup #

Patch Set 3 : nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A LayoutTests/fast/canvas/bug503422.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/bug503422-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasPathMethods.cpp View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 895153002 Patch 100001

Messages

Total messages: 7 (2 generated)
Justin Novosad
PTAL
5 years, 6 months ago (2015-06-26 15:17:35 UTC) #2
Stephen White
https://codereview.chromium.org/1212423002/diff/1/Source/core/html/canvas/CanvasPathMethods.cpp File Source/core/html/canvas/CanvasPathMethods.cpp (right): https://codereview.chromium.org/1212423002/diff/1/Source/core/html/canvas/CanvasPathMethods.cpp#newcode187 Source/core/html/canvas/CanvasPathMethods.cpp:187: // Compensate for numerical precision issues in fmodf (c.f. ...
5 years, 6 months ago (2015-06-26 15:38:21 UTC) #3
Stephen White
LGTM
5 years, 6 months ago (2015-06-26 15:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212423002/40001
5 years, 6 months ago (2015-06-26 15:47:03 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 17:02:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197931

Powered by Google App Engine
This is Rietveld 408576698