scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json - Issue 1212413002: Pass all compile targets to "analyze"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

Issue 1212413002: Pass all compile targets to "analyze" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: do not include 'all' Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/chromium_trybot.py ('k') | scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json b/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

index ec800d64daa4c8b7b8eda5be6e5a022d15b556a9..601a9f8636fb3469e0778c52a93d892862a50774 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json

@@ -194,7 +194,7 @@

"-u",

"[SLAVE_BUILD]/src/build/gyp_chromium",

"--analyzer",

- "{\"files\": [\"foo.cc\"], \"targets\": [\"angle_unittests_run\", \"base_unittests\", \"chrome\", \"content_gl_tests_run\", \"gl_tests_run\", \"tab_capture_end2end_tests_run\", \"telemetry_gpu_test_run\"]}",

+ "{\"files\": [\"foo.cc\"], \"targets\": [\"angle_unittests_run\", \"base_unittests\", \"chrome\", \"chromium_swarm_tests\", \"content_gl_tests_run\", \"gl_tests_run\", \"tab_capture_end2end_tests_run\", \"telemetry_gpu_test_run\"]}",

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",