Pass all compile targets to "analyze"

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from infra.libs.infra_types import freeze
 
 DEPS = [
   'bot_update',
   'chromium',
   'chromium_android',
@@ skipping 444 matching lines @@
 
   compile_targets, tests_including_triggered = \
       api.chromium_tests.get_compile_targets_and_tests(
           bot_config['mastername'],
           bot_config['buildername'],
           master_dict,
           test_spec,
           override_bot_type='builder_tester',
           override_tests=tests)
 
+  targets_for_analyze = sorted(set(
+      all_compile_targets(api, tests + tests_including_triggered) +

[sky, 2015/06/29 02:28:25]

This certainly works, but shouldn't we instead warn/assert that compile_targets
shouldn't included all? With the way you have it now all is silently ignored.
Also, I think it's 'All'.

[Paweł Hajdan Jr., 2015/06/29 12:38:22]

That's right. Do you think it's blocking this CL?

We might have a chicken and egg problem here: some bots may be using "all"
because of a hack in chromium_tests.analyze (that I was trying to get rid of in
https://codereview.chromium.org/1187863002).

My plan is to get rid of the need for that hack. I'd just like to move in small
steps to avoid breakages, and this CL is just a small step. This is mostly based
on
https://groups.google.com/a/chromium.org/d/msg/infra-dev/3kUd4emLyBA/W3OcZo8-...
("In short, we should change the filter/api.py script to ignore the
'build_targets' param, and use just the 'targets' param 
in the output; once we've done that, we should remove 'build_targets'
altogether.").

I believe that in order to ignore "build_targets" (a.k.a. "compile_targets") I'd
first need to ensure all targets we may want to compile are passed in "targets"
(a.k.a. "exes" or "matching_exes").

I could make a CL which does all of that in one step, it just sounds very risky.
I thought I'd first add things to exes (i.e. this CL). It shouldn't break
anything. Then I'd look into bots compiling "all" (no special alerts are needed,
it's all in the configs), and then making a change to the recipe to ignore
"build_targets" (compile_targets) and only use matching_exes while removing
"all" from the configs.

Does above plan make sense to you? Feel free to make recommendations for a
better one.
That's why code below uses t.lower() - it seems to me it's All on Windows but
all on other platforms. Note that all_compile_targets is a function call that is
only moved in this CL without modification.

+      [t for t in compile_targets if t.lower() != 'all']))
   requires_compile, matching_exes, compile_targets = \
       api.chromium_tests.analyze(
           affected_files,
-          all_compile_targets(api, tests + tests_including_triggered),
+          targets_for_analyze,
           compile_targets,
           'trybot_analyze_config.json')
 
   if not requires_compile:
     return
 
   tests = tests_in_compile_targets(api, matching_exes, tests)
   tests_including_triggered = tests_in_compile_targets(
       api, matching_exes, tests_including_triggered)
 
@@ skipping 588 matching lines @@
 
   yield (
     api.test('swarming_paths') +
     api.properties.tryserver(
       mastername='tryserver.chromium.linux',
       buildername='linux_chromium_rel_ng',
       path_config='swarming',
     ) +
     api.platform.name('linux')
   )