Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212363005: Make sp- via support SkDrawables; add a GM to test it. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make sp- via support SkDrawables; add a GM to test it. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d2baa9093876357c8fbf4bc74d10d68b4c026c6f

Patch Set 1 #

Patch Set 2 : Clearer ownership. #

Patch Set 3 : support GMs without drawables too... #

Patch Set 4 : wtf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -9 lines) Patch
M dm/DMSrcSink.cpp View 1 2 4 chunks +18 lines, -9 lines 0 comments Download
A gm/drawable.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M src/core/SkRecorder.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212363005/40001
5 years, 5 months ago (2015-07-07 16:24:55 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1881)
5 years, 5 months ago (2015-07-07 16:26:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212363005/60001
5 years, 5 months ago (2015-07-07 16:29:10 UTC) #6
mtklein_C
5 years, 5 months ago (2015-07-07 16:34:42 UTC) #8
reed1
lgtm
5 years, 5 months ago (2015-07-07 16:36:18 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 16:36:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212363005/60001
5 years, 5 months ago (2015-07-07 16:42:49 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 16:43:32 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d2baa9093876357c8fbf4bc74d10d68b4c026c6f

Powered by Google App Engine
This is Rietveld 408576698