Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1212363002: Pass explicitly the frame to HistoryController::GoToEntry (Closed)

Created:
5 years, 5 months ago by nasko
Modified:
5 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass explicitly the frame to HistoryController::GoToEntry When doing a session history navigation cross-process in a frame which already has a proxy, the proxy is replaced by a new real frame. In this case, HistoryController doesn't know about the new frame it needs to interact with, so this CL adds it as an explicit parameter in GoToEntry. This scenario becomes possible once we stop using swapped out frames for navigation in regular Chrome. BUG=357747 Committed: https://crrev.com/ea32ae1fb0617e83b96b965ba10a31df38aa3269 Cr-Commit-Position: refs/heads/master@{#336370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M content/renderer/history_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/history_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nasko
Hey Avi, Can you review this CL for me? It is a split from the ...
5 years, 5 months ago (2015-06-26 14:51:40 UTC) #2
Avi (use Gerrit)
lgtm Still looks good to me from last time.
5 years, 5 months ago (2015-06-26 15:10:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212363002/1
5 years, 5 months ago (2015-06-26 15:11:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-26 15:16:11 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-26 15:17:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea32ae1fb0617e83b96b965ba10a31df38aa3269
Cr-Commit-Position: refs/heads/master@{#336370}

Powered by Google App Engine
This is Rietveld 408576698