Issue 1212343009: SkyDemo.apk should show thumbmails when offline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1212343009: SkyDemo.apk should show thumbmails when offline (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1, eseidel

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

SkyDemo.apk should show thumbmails when offline We now get the thumbnails from the root bundle when offline and otherwise fall back to the network. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/59ed477c92807ddad7f14e40b2431ba8f13b5959

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
	M	sky/sdk/example/demo_launcher/lib/main.dart	View		5 chunks	+13 lines, -3 lines	0 comments	Download
	M	sky/sdk/lib/painting/box_painter.dart	View		3 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 5 months ago (2015-07-06 23:32:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
59ed477c92807ddad7f14e40b2431ba8f13b5959 (presubmit successful).